Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(demo): check that icons are resized on e2e screenshots #6588

Merged
merged 1 commit into from
Jan 30, 2024
Merged

chore(demo): check that icons are resized on e2e screenshots #6588

merged 1 commit into from
Jan 30, 2024

Conversation

splincode
Copy link
Member

image

@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Jan 29, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions GitHub Actions
Copy link
Contributor

Visit the preview URL for this PR (updated for commit 920d23b):

https://taiga-ui--pr6588-splincode-chore-e2e-jm7rbjvw.web.app

(expires Tue, 30 Jan 2024 07:46:12 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@bundlemon BundleMon
Copy link

bundlemon bot commented Jan 29, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 345.96KB +10%
✅ demo/browser/vendor.(hash).js
 214.62KB +10%
✅ demo/browser/runtime.(hash).js
 34.15KB +10%
✅ demo/browser/polyfills.(hash).js
 11.24KB +10%
✅ demo/browser/styles.(hash).css
 1.06KB +10%

Total files change +2B 0%

Groups updated (1)
Status Path Size Limits
✅ demo/browser/*..js
 2.18MB (+197B +0.01%) -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

waterplea
waterplea approved these changes Jan 29, 2024
View reviewed changes
projects/demo/src/modules/experimental/avatar/examples/3/index.html
<tui-avatar size="s">S</tui-avatar>
<tui-avatar size="xs">XS</tui-avatar>
<tui-avatar size="xxs">XXS</tui-avatar>
<div class="row">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use ngFor

@splincode splincode merged commit 7fb0c63 into main Jan 30, 2024
25 of 26 checks passed
@splincode splincode deleted the splincode/chore/e2e branch January 30, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waterplea waterplea waterplea approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi

@vladimirpotekhin vladimirpotekhin Awaiting requested review from vladimirpotekhin

@nsbarsukov nsbarsukov Awaiting requested review from nsbarsukov

Assignees

@splincode splincode

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@splincode @waterplea